Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly encode decimal values for frontend #2550

Merged
merged 5 commits into from
Aug 12, 2019
Merged

correctly encode decimal values for frontend #2550

merged 5 commits into from
Aug 12, 2019

Conversation

ayrat555
Copy link
Contributor

after recent Decimal library update, Poison started encoding decimal values differently. This PR introduces Poison encoder implementation for decimal values.

Changelog

  • correctly encode decimal values for frontend

pasqu4le
pasqu4le approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question. Apart from that I'd say that it would be a good idea to add a small test just to check that it encodes the way we we expect it to.

apps/block_scout_web/lib/block_scout_web/chain.ex Show resolved Hide resolved
@vbaranov vbaranov merged commit d44f42b into master Aug 12, 2019
@vbaranov vbaranov deleted the ab-fix-exchange-rates branch August 13, 2019 09:30
@vbaranov vbaranov mentioned this pull request Aug 13, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqu4le pasqu4le pasqu4le approved these changes

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery Awaiting requested review from saneery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayrat555 @vbaranov @pasqu4le