Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated extract-text-webpack-plugin with mini-css-extract-plugin #2435

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Replace deprecated extract-text-webpack-plugin with mini-css-extract-plugin #2435

merged 3 commits into from
Jul 30, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jul 25, 2019 •
edited
Loading

A part of #2390

Motivation

mini-css-extract-plugin advantages

Compared to the extract-text-webpack-plugin:

Async loading
No duplicate compilation (performance)
Easier to use
Specific to CSS

Changelog

➖ deprecated extract-text-webpack-plugin
➕ mini-css-extract-plugin
➕ optimize-css-assets-webpack-plugin for minimizing CSS assets in prod
➕ terser-webpack-plugin to minify JS in prod

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov mentioned this pull request Jul 25, 2019
Closed
5 tasks
@vbaranov vbaranov self-assigned this Jul 25, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jul 25, 2019
@coveralls
Copy link

coveralls commented Jul 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 5d440917-ff18-43ff-b29a-a7043480af7e

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 79.319%
Totals Coverage Status
Change from base Build 3ec20c7a-6267-472d-b111-966aa13ac742: 0.2%
Covered Lines: 5151
Relevant Lines: 6494
💛 - Coveralls

@vbaranov vbaranov merged commit 4db6bea into master Jul 30, 2019
@vbaranov vbaranov deleted the vb-mini-css-extract-plugin branch July 30, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqu4le pasqu4le pasqu4le approved these changes

@saneery saneery saneery approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@Heimdell Heimdell Heimdell approved these changes

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vbaranov @coveralls @Heimdell @ayrat555 @saneery @pasqu4le