-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force to show address view for checksummed address even if it is not in DB #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build a7eccdb5-57b5-475f-8c5c-cfaf298f9b08
💛 - Coveralls |
ayrat555
approved these changes
Jul 25, 2019
saneery
approved these changes
Jul 25, 2019
pasqu4le
approved these changes
Jul 25, 2019
…rk/blockscout into vb-force-show-not-found-address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue https://forum.poa.network/t/blockscout-doesnt-show-address-info/2843
Motivation
In the described in the link above case, a developer uses a link to Blockscout address page and if there were no transactions with this address, we show 404 page, but instead, I think we should display an address view, if this address is checksummed.
The possible use case can be if the user sends a transaction from a dapp/wallet to an address, which never has in/out transactions in the blockchain and w/out waiting of confirmation goes to Blockscout to see the balance update. To show address view with a zero balance is less confusing than to display 404 page.
Changelog
Enhancements
8dc5f00 - Address view for checksummed address is allowed
1c67e56 - Hide Last Balance Update in address view if there is no fetched_coinbalance_block_number, because, I suppose, we don't want to trigger on-demand balance update if the address has no transactions yet
Bug Fixes
a789586 - chore, fixing of
expected action/2 to return a Plug.Conn, all plugs must receive a connection (conn) and return a connection, got: {:error, :not_found}
error when opening page likehttp://localhost:4000/address/{address_hahs}/coin_balances
with inexisting address. This related error was detected while working on this PR.Checklist for your PR
CHANGELOG.md
with this PR