Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable network selector when is empty #2379

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Disable network selector when is empty #2379

merged 2 commits into from
Jul 18, 2019

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Jul 18, 2019 •
edited
Loading

#2132

Motivation

Env variable SUPPORTED_CHAINS may be ="[]", then we have empty network selector

image

@coveralls
Copy link

coveralls commented Jul 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build ac84e4fa-efba-42f1-87b9-35f629502f81

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.93%
Totals Coverage Status
Change from base Build eb6404ac-7c9f-453d-ab5d-45a2d93d12dd: 0.0%
Covered Lines: 5203
Relevant Lines: 6429
💛 - Coveralls

@saneery saneery marked this pull request as ready for review July 18, 2019 09:08
@saneery saneery added the ready for review This PR is ready for reviews. label Jul 18, 2019
ayrat555
ayrat555 reviewed Jul 18, 2019
View reviewed changes
Copy link
Contributor

@ayrat555 ayrat555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

pasqu4le
pasqu4le approved these changes Jul 18, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@saneery saneery force-pushed the disable-empty-network-selector branch from 42aae9b to 4d0c221 Compare July 18, 2019 11:29
@vbaranov vbaranov merged commit 04587ea into master Jul 18, 2019
@vbaranov vbaranov deleted the disable-empty-network-selector branch July 18, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqu4le pasqu4le pasqu4le approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@vbaranov vbaranov Awaiting requested review from vbaranov

Assignees
No one assigned
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saneery @coveralls @ayrat555 @pasqu4le @vbaranov