Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update created_contract_code_indexed_at on transaction import conflict #2375

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Update created_contract_code_indexed_at on transaction import conflict #2375

merged 1 commit into from
Jul 17, 2019

Conversation

pasqu4le
Copy link
Contributor

Solves a problem describe in a #2105 comment.

Motivation

The problem is that a transaction's created_contract_code_indexed_at gets ignored during a conflicting update, so it is not updated.
In particular it is not reset to NULL and this has been source of errors.

Changelog

Bug Fixes

Add created_contract_code_indexed_at as a field to check and update during an import with conflict.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@pasqu4le pasqu4le self-assigned this Jul 17, 2019
@pasqu4le
Update created_contract_code_indexed_at on transaction import conflict
6615e85 
Problem: a transaction created_contract_code_indexed_at gets ignored during a conflicting update, so it is not updated.
In particular it is not reset to NULL and this has been source of errors.

Solution: add it as a field to check and update during an import with conflict.
@pasqu4le pasqu4le force-pushed the pp-created_contract_code_indexed_at-updating branch from 434a821 to 6615e85 Compare July 17, 2019 13:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 641e1231-0b6e-4aab-94c9-6f44e2a98ccd

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 80.93%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/market/market_history_cache.ex 1 83.33%
Totals Coverage Status
Change from base Build 182ab033-a760-4048-b270-d8fc91072ab2: -0.02%
Covered Lines: 5203
Relevant Lines: 6429
💛 - Coveralls

@pasqu4le pasqu4le added the ready for review This PR is ready for reviews. label Jul 17, 2019
@pasqu4le pasqu4le mentioned this pull request Jul 17, 2019
Closed
ayrat555
ayrat555 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@ayrat555 ayrat555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

vbaranov added a commit that referenced this pull request Jul 17, 2019
@vbaranov
#2375
ceeef32
@vbaranov vbaranov merged commit 443d272 into master Jul 17, 2019
@vbaranov vbaranov deleted the pp-created_contract_code_indexed_at-updating branch July 17, 2019 17:13
@vbaranov vbaranov mentioned this pull request Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery Awaiting requested review from saneery

Assignees

@pasqu4le pasqu4le

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pasqu4le @coveralls @vbaranov @ayrat555