Avoid fetching internal transactions of blocks that still need refetching #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqu4le
force-pushed
the
pp-avoid-internal-transactions-of-blocks-to-refetch
branch
from
ea8cb60
to
5d68fce
Compare
Pull Request Test Coverage Report for Build bd487f5e-59d4-47ec-ab83-fa1a16a4f365
💛 - Coveralls |
vbaranov
approved these changes
Jul 11, 2019
ayrat555
approved these changes
Jul 11, 2019
Heimdell
approved these changes
Jul 11, 2019
…hing Problem: blocks that need refetching may have the wrong transactions, so if internal transactions for this block are fetched they can (in some cases) fail to be inserted because their transaction does not exist. As a consequence this causes their insertion to fail multiple time before the block gets refetched. Solution: exclude blocks that need refetching from internal transactions indexing.
pasqu4le
force-pushed
the
pp-avoid-internal-transactions-of-blocks-to-refetch
branch
from
5d68fce
to
c38aea8
Compare
|
@ayrat555 right! I added it as a doctest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2105
Motivation
Blocks that need refetching may have the wrong transactions, so if internal transactions for this block are fetched they can (in some cases) fail to be inserted because their transaction does not exist.
As a consequence this causes their insertion to fail multiple time before the block gets refetched.
Changelog
This PR excludes blocks that need refetching from internal transactions indexing.
Checklist for your PR
CHANGELOG.mdwith this PR