Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix constructor arguments verifications #2326

Merged
merged 10 commits into from
Jul 12, 2019
Merged

fix constructor arguments verifications #2326

merged 10 commits into from
Jul 12, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 9, 2019 •
edited
Loading

  • Some constructor arguments have multiple constructors arguments appended at the end
  • Older smart contracts don't have a whisper code

Changelog

  • fix nested constructor arguments
  • fix verification of older smart contracts with constructor args

@coveralls
Copy link

coveralls commented Jul 9, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 34c6f883-bd9f-4d47-98da-011f40158340

  • 11 of 13 (84.62%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 80.711%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex 9 11 81.82%
Totals Coverage Status
Change from base Build 5ef95cd5-dc31-4d6b-bf7b-b8f704c50c14: -0.2%
Covered Lines: 5180
Relevant Lines: 6418
💛 - Coveralls

@ayrat555 ayrat555 changed the title fix nested constructor arguments fix constructor arguments verifications Jul 10, 2019
vbaranov
vbaranov approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 some minor comments

apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex Show resolved Hide resolved
apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex Show resolved Hide resolved
pasqu4le
pasqu4le approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion

apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex Outdated Show resolved Hide resolved
@vbaranov vbaranov merged commit 50d57ee into master Jul 12, 2019
@vbaranov vbaranov deleted the ab-fix-nested-constructor-arguments branch July 12, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqu4le pasqu4le pasqu4le approved these changes

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery Awaiting requested review from saneery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayrat555 @coveralls @vbaranov @pasqu4le