Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse url for api docs #2310

Merged
merged 4 commits into from
Jul 9, 2019
Merged

parse url for api docs #2310

merged 4 commits into from
Jul 9, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 8, 2019

the scheme was hardcoded to HTTP in api docs. Because of that api requests didn't work if the scheme is HTTPS

Changelog

  • parse url for api docs

@coveralls
Copy link

coveralls commented Jul 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 8208be94-f678-4291-b37f-620c430a1649

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 80.97%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/views/api_docs_view.ex 1 92.86%
apps/explorer/lib/explorer/market/market_history_cache.ex 2 88.89%
Totals Coverage Status
Change from base Build d28b73fc-2367-4891-85c9-038031a4a315: -0.03%
Covered Lines: 5161
Relevant Lines: 6374
💛 - Coveralls

@vbaranov vbaranov merged commit cb801b0 into master Jul 9, 2019
@vbaranov vbaranov deleted the ab-parse-url-for-api-docs branch July 9, 2019 11:47
vbaranov added a commit that referenced this pull request Jul 9, 2019
@vbaranov
revert #2310
314a144
vbaranov added a commit that referenced this pull request Jul 9, 2019
@vbaranov
revert #2310
8882461
vbaranov added a commit that referenced this pull request Jul 9, 2019
@vbaranov
revert #2310
279d8ba
vbaranov added a commit that referenced this pull request Jul 10, 2019
@vbaranov
Revert #2310
cc23b25
vbaranov added a commit that referenced this pull request Jul 10, 2019
@vbaranov
Revert #2310
3d42942
vbaranov added a commit that referenced this pull request Jul 10, 2019
@vbaranov
Revert #2310
3b255eb
vbaranov added a commit that referenced this pull request Jul 10, 2019
@vbaranov
Revert #2310
a4036af
vbaranov added a commit that referenced this pull request Jul 10, 2019
@vbaranov
Revert #2310
0458f67
vbaranov added a commit that referenced this pull request Jul 10, 2019
@vbaranov
Revert #2310
3c406e4
vbaranov added a commit that referenced this pull request Jul 10, 2019
@vbaranov
revert #2310
d363107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqu4le pasqu4le pasqu4le approved these changes

@saneery saneery saneery approved these changes

@vbaranov vbaranov vbaranov approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le