Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eth_get_balance.json to AddressView's render #2290

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Add eth_get_balance.json to AddressView's render #2290

merged 2 commits into from
Jul 5, 2019

Conversation

pasqu4le
Copy link
Contributor

@pasqu4le pasqu4le commented Jul 3, 2019 •
edited
Loading

Fixes #2279

It turns out a clause for render eth_get_balance.json went missing in #2100 (probably during a rebase/merge) and so it was enough to rewrite it.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@pasqu4le pasqu4le self-assigned this Jul 3, 2019
@pasqu4le
Add eth_get_balance.json to AddressView render
7e38684 
Problem: the eth_get_balance endpoint fails returning a 500 error when the URL is correct.

Solution: turns out a clause for render eth_get_balance.json went missing (probably during a rebase) and so it was enough to rewrite it.
@pasqu4le pasqu4le force-pushed the pp-fix-eth_get_balance-endpoint branch from ad3c298 to 7e38684 Compare July 3, 2019 16:09
@pasqu4le pasqu4le added ready for review This PR is ready for reviews. and removed in progress labels Jul 3, 2019
@coveralls
Copy link

coveralls commented Jul 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 7cf3632d-7704-4fe9-8ed0-fd8735c5768a

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 80.914%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/api/rpc/address_view.ex 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/market/market_history_cache.ex 1 83.33%
Totals Coverage Status
Change from base Build cc09b52a-c21d-4c0d-abaa-ea1da80d057f: -0.03%
Covered Lines: 5151
Relevant Lines: 6366
💛 - Coveralls

ayrat555
ayrat555 approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@ayrat555 ayrat555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@vbaranov vbaranov merged commit b8cb68d into master Jul 5, 2019
@vbaranov vbaranov deleted the pp-fix-eth_get_balance-endpoint branch July 5, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saneery saneery saneery approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@vbaranov vbaranov vbaranov approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees

@pasqu4le pasqu4le

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth_get_balance api endpoint returns 500 error
5 participants
@pasqu4le @coveralls @vbaranov @ayrat555 @saneery