Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional websockets for dev environment #2289

Merged
merged 3 commits into from
Jul 4, 2019
Merged

Optional websockets for dev environment #2289

merged 3 commits into from
Jul 4, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jul 3, 2019 •
edited
Loading

Motivation

Optional web sockets are supported only for prod environment

Changelog

Enhancements

  • extend support of optional websockets to dev environment

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jul 3, 2019
@vbaranov vbaranov self-assigned this Jul 3, 2019
@coveralls
Copy link

coveralls commented Jul 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 63b9969c-aafb-4b3b-8c81-559a0d4109d0

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 81.037%
Totals Coverage Status
Change from base Build 386557a0-9cf0-4a24-8713-5ca6d5b6b50f: 0.09%
Covered Lines: 5158
Relevant Lines: 6365
💛 - Coveralls

@vbaranov vbaranov merged commit 639a647 into master Jul 4, 2019
@vbaranov vbaranov deleted the vb-optional-ws-for-dev branch July 4, 2019 13:07
@vbaranov vbaranov mentioned this pull request Apr 22, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqu4le pasqu4le pasqu4le approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery Awaiting requested review from saneery

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbaranov @coveralls @ayrat555 @pasqu4le