Add transactions cache #2283
Merged
Add transactions cache #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqu4le
force-pushed
the
pp-transactions-cache
branch
from
15ed540
to
35d19cd
Compare
Pull Request Test Coverage Report for Build 3d7d7366-a31e-43db-bf88-045833e0f752
💛 - Coveralls |
ayrat555
reviewed
Jul 2, 2019
| @@ -6,6 +6,13 @@ defmodule BlockScoutWeb.TransactionControllerTest do | |||
|
|
|||
| alias Explorer.Chain.Transaction | |||
|
|
|||
| setup do | |||
| Supervisor.terminate_child(Explorer.Supervisor, {ConCache, :transactions}) | |||
There was a problem hiding this comment.
can we add it to DataCase instead of adding to all test files?
There was a problem hiding this comment.
@ayrat555 not really, being these BlockScoutWeb tests they don't use Explorer.DataCase.
However they use BlockScoutWeb.FeatureCase and BlockScoutWeb.ConnCase, so I put the restart in their setup and it seems to be working.
pasqu4le
force-pushed
the
pp-transactions-cache
branch
2 times, most recently
from
7d0ca90
to
2d25026
Compare
pasqu4le
force-pushed
the
pp-transactions-cache
branch
from
2d25026
to
18e5c76
Compare
vbaranov
approved these changes
Jul 3, 2019
|
@pasqu4le |
Problem: due to the unsatisfying performance of the main page some ETS-based cache has been deemed necessary. In this particular case one for the most recent collated transactions. Solution: implementation of said transactions cache
pasqu4le
force-pushed
the
pp-transactions-cache
branch
from
7d4f1a1
to
bef66e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2250
Checklist for your PR
CHANGELOG.mdwith this PR