Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide logs search if there are no logs #2247

Merged
merged 4 commits into from
Jun 28, 2019
Merged

hide logs search if there are no logs #2247

merged 4 commits into from
Jun 28, 2019

Conversation

ayrat555
Copy link
Contributor

Current logic:

img

Changelog

  • hide logs search if there are no logs

@coveralls
Copy link

coveralls commented Jun 26, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 74ed515c-6efb-41e6-be15-8f1df373878f

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.127%
Totals Coverage Status
Change from base Build 0cd5dd0c-b7cb-4c37-aa70-9b8c92c71689: 0.1%
Covered Lines: 5111
Relevant Lines: 6300
💛 - Coveralls

vbaranov
vbaranov approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 please add changelog entry

@ayrat555
Copy link
Contributor Author

@vbaranov done

vbaranov added a commit that referenced this pull request Jun 27, 2019
@vbaranov
#2247
24d3d00
@ayrat555 ayrat555 merged commit 3c6abf4 into master Jun 28, 2019
@ayrat555 ayrat555 deleted the ab-hide-logs-search branch June 28, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saneery saneery saneery approved these changes

@vbaranov vbaranov vbaranov approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayrat555 @coveralls @vbaranov @saneery