-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce transaction status and error constraint #2198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 58cbc661-1c9a-4d30-95b4-134d736a887b
💛 - Coveralls |
tests are failing |
pasqu4le
force-pushed
the
reduce-transaction-status-constraint
branch
2 times, most recently
from
June 20, 2019 12:54
edd3511
to
2e1b6ea
Compare
pasqu4le
added
in progress
and removed
ready for review
This PR is ready for reviews.
labels
Jun 20, 2019
pasqu4le
force-pushed
the
reduce-transaction-status-constraint
branch
from
June 20, 2019 15:18
2e1b6ea
to
ac6da94
Compare
pasqu4le
force-pushed
the
reduce-transaction-status-constraint
branch
from
June 20, 2019 16:20
ac6da94
to
afc7578
Compare
pasqu4le
changed the title
Reduce transaction status constraint
Reduce transaction status and error constraint
Jun 20, 2019
pasqu4le
added
ready for review
This PR is ready for reviews.
and removed
in progress
labels
Jun 20, 2019
ayrat555
approved these changes
Jun 21, 2019
vbaranov
approved these changes
Jun 28, 2019
saneery
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Block invalidation can causes transactions to be refetched while previous internal transactions still exist, failing inserts/updates because of check constraints.
Because of this it is necessary to lift all checks on status and error, except the ones over
block_hash
(ifNULL
or not) and onstatus = 0
(or not).Checklist for your PR
CHANGELOG.md
with this PR