Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nethermind client fixes #2196

Merged
merged 13 commits into from
Jul 4, 2019
Merged

Nethermind client fixes #2196

merged 13 commits into from
Jul 4, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jun 19, 2019

fixes

Retrying.
2019-06-19T12:34:06.538 application=indexer fetcher=block_catchup first_block_number=4583792 last_block_number=4583783 [error] ** (MatchError) no match of right hand side value: false
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/block.ex:78: EthereumJSONRPC.Block.from_response/2
    (elixir) lib/enum.ex:1327: Enum."-map/2-lists^map/1-0-"/2
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/blocks.ex:35: EthereumJSONRPC.Blocks.from_responses/2
    (ethereum_jsonrpc) lib/ethereum_jsonrpc.ex:439: EthereumJSONRPC.fetch_blocks_by_params/3
    (indexer) lib/indexer/block/fetcher.ex:127: Indexer.Block.Fetcher.fetch_and_import_range/2
    (indexer) lib/indexer/block/catchup/fetcher.ex:187: Indexer.Block.Catchup.Fetcher.fetch_and_import_range_from_sequence/3
    (elixir) lib/task/supervised.ex:90: Task.Supervised.invoke_mfa/2
    (elixir) lib/task/supervised.ex:35: Task.Supervised.reply/5
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3

Motivation

  • Nethermind client has some differences from other clients

Changelog

  • fix response without request id

@coveralls
Copy link

coveralls commented Jun 19, 2019

Pull Request Test Coverage Report for Build 9e3ed368-4cce-4a1c-a6be-1458c993f102

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 80.98%

Totals Coverage Status
Change from base Build 386557a0-9cf0-4a24-8713-5ca6d5b6b50f: 0.04%
Covered Lines: 5156
Relevant Lines: 6367

💛 - Coveralls

@ayrat555 ayrat555 changed the title fix response without request id Nethermind client fixes Jun 19, 2019
vbaranov added a commit that referenced this pull request Jun 19, 2019
vbaranov added a commit that referenced this pull request Jul 1, 2019
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor question

apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http.ex Outdated Show resolved Hide resolved
@vbaranov vbaranov merged commit d4bce47 into master Jul 4, 2019
@vbaranov vbaranov deleted the ab-fix-response-without-id branch July 4, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants