Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show all token transfers #2190

Merged
merged 17 commits into from
Jun 27, 2019
Merged

show all token transfers #2190

merged 17 commits into from
Jun 27, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jun 18, 2019

resolves #1792
img
img1

Motivation

  • show all token transfers for the token transfer transaction
  • add generic Token Transfer title for transactions for which we couldn't identify a type
  • fix transactions like 0xbeea8c6b013cd052c8ef9e3650c86157d4e502f0fa78c6320e4366670b6b798a which have their tokens split into multiple internal transactions

Changelog

  • show all token transfers

@coveralls
Copy link

coveralls commented Jun 18, 2019

Pull Request Test Coverage Report for Build 4629562d-fa54-4731-b88e-dc19f2fb62f8

  • 9 of 12 (75.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 80.98%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/transaction_view.ex 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/internal_transaction.ex 2 58.62%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 88.0%
Totals Coverage Status
Change from base Build f7af39be-7886-42ee-a941-114a4933d42c: -0.2%
Covered Lines: 5041
Relevant Lines: 6225

💛 - Coveralls

vbaranov added a commit that referenced this pull request Jun 19, 2019
@vbaranov vbaranov requested review from Heimdell and removed request for zachdaniel June 22, 2019 15:04
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

  1. There is a big space between transfer values

Screenshot 2019-06-25 at 00 34 11

/tx/0x137acc29647ec5bb0dd03d33779ca34501541f05b83a18a35ac93edaf0f963c5/token_transfers

  1. Why are token transfers not recognized in this tx? /tx/0x6d31e77f60baec0c3d54e569b8e9bda6f31c91272cbf1e82324843a5355bcbd4/token_transfers

vbaranov added a commit that referenced this pull request Jun 24, 2019
@ayrat555
Copy link
Contributor Author

@vbaranov

  1. I'll fix that now
  2. Because it has ETH value

@ayrat555
Copy link
Contributor Author

@vbaranov I addressed your comment about spaces

@vbaranov
Copy link
Member

@ayrat555 please attach the screenshot of the summary block after the fix.

@ayrat555
Copy link
Contributor Author

@vbaranov done

@vbaranov vbaranov self-requested a review June 27, 2019 11:48
@vbaranov vbaranov merged commit ece4392 into master Jun 27, 2019
@vbaranov vbaranov deleted the ab-show-all-token-transfers branch June 27, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the summary of total tokens transferred for 1 tx
5 participants