Filter pending logs #2148
Merged
Filter pending logs #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build afd47931-85b8-4d2d-84cc-9e38697d5171
💛 - Coveralls |
pasqu4le
approved these changes
Jun 12, 2019
zachdaniel
approved these changes
Jun 12, 2019
vbaranov
reviewed
Jun 13, 2019
| }, | ||
| %{ | ||
| "address" => "0x8bf38d4764929064f2d4d3a56520a76ab3df415c", | ||
| "blockHash" => "0xf6b4b8c88df3ebd252ec476328334dc026cf66606a84fb769b3d3cbccc8471bd", |
There was a problem hiding this comment.
@saneery The update in the test for pending logs contradicts to the statement in the description of PR
There is a problem with pending logs, they don't have fields blockNumber, transactionHash and logIndex
Doesn't it?
I see all of those fields in the test for pending log.
vbaranov
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2067
Motivation
There is a problem with pending logs, they don't have fields
blockNumber,transactionHashandlogIndexopenethereum/parity-ethereum#10697Changelog