Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect token transfer type #2093

Merged
merged 6 commits into from
Jun 5, 2019
Merged

detect token transfer type #2093

merged 6 commits into from
Jun 5, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jun 4, 2019 •
edited
Loading

resolves #1973

Changelog

  • detect token transfer type for deprecated erc721 spec

@coveralls
Copy link

coveralls commented Jun 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build f3a722ad-a04e-4bd3-bf5c-0ba78a18f8a0

  • 21 of 27 (77.78%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 80.879%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/chain.ex 20 26 76.92%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/chain.ex 1 84.1%
Totals Coverage Status
Change from base Build 5bbe46b9-e3ea-4bfb-9749-9d6213e7c14a: 0.1%
Covered Lines: 4822
Relevant Lines: 5962
💛 - Coveralls

vbaranov added a commit that referenced this pull request Jun 4, 2019
@vbaranov
#2093
9de9144
vbaranov
vbaranov approved these changes Jun 5, 2019
View reviewed changes
apps/explorer/lib/explorer/chain.ex Outdated Show resolved Hide resolved
@ayrat555 ayrat555 merged commit 55fd323 into master Jun 5, 2019
@ayrat555 ayrat555 deleted the ab-erc721-transfer branch June 5, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqu4le pasqu4le pasqu4le approved these changes

@saneery saneery saneery approved these changes

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced display of ERC-721 token transfer summary
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le