Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow total_difficuly to be nil #2083

Merged
merged 5 commits into from
Jun 4, 2019
Merged

allow total_difficuly to be nil #2083

merged 5 commits into from
Jun 4, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jun 3, 2019

fixes #2079

Changelog

  • allow total_difficuly to be nil

@vbaranov vbaranov requested a review from saneery June 3, 2019 08:13
@coveralls
Copy link

coveralls commented Jun 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2844996d-0d26-49e3-a23e-7ba3c3393f82

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.675%
Totals Coverage Status
Change from base Build 2a4e9af9-4079-4746-be51-464b78ca22ca: 0.0%
Covered Lines: 4805
Relevant Lines: 5956
💛 - Coveralls

@vbaranov vbaranov merged commit 32863ab into master Jun 4, 2019
@vbaranov vbaranov deleted the ab-allow-total-difficulty-to-be-nil branch June 4, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saneery saneery saneery approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@vbaranov vbaranov vbaranov approved these changes

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow null totalDifficulty for uncles
5 participants
@ayrat555 @coveralls @vbaranov @zachdaniel @saneery