Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout for geth indexers #2055

Merged
merged 2 commits into from
May 29, 2019
Merged

Increase timeout for geth indexers #2055

merged 2 commits into from
May 29, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 29, 2019 •
edited
Loading

#1869 (comment)

Motivation

We should increase the timeout for geth indexers after implementing of #1869

Changelog

  • increasing of the timeout for geth indexers from 1 minute to 10 minutes

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov added the ready for review This PR is ready for reviews. label May 29, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3a7d50c0-25a4-4050-bb4c-1a96bd06ff4f

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 80.901%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
Totals Coverage Status
Change from base Build 1534e6a2-23eb-4d8c-99c3-c0b8f9bbd713: 0.08%
Covered Lines: 4761
Relevant Lines: 5885
💛 - Coveralls

@vbaranov vbaranov merged commit 32472a0 into master May 29, 2019
@vbaranov vbaranov deleted the geth-timeout-increase branch May 29, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@saneery saneery Awaiting requested review from saneery

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vbaranov @coveralls @zachdaniel @ayrat555 @saneery @pasqu4le