Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show creating internal transactions #2047

Merged
merged 2 commits into from
May 30, 2019
Merged

fix: show creating internal transactions #2047

merged 2 commits into from
May 30, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented May 28, 2019 •
edited
Loading

Resolves: #1938

Changelog

Bug Fixes

  • Show internal transactions that created the address when filtering for internal transactions to that address.

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@zachdaniel zachdaniel force-pushed the include-contract-creation-internal-transactions branch from a70285a to 6f3accc Compare May 28, 2019 20:35
@coveralls
Copy link

coveralls commented May 28, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build d0f551f8-23e9-4124-9059-af4b84886b20

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.827%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/chain/internal_transaction.ex 0 1 0.0%
Totals Coverage Status
Change from base Build 310a107e-df33-4f13-b380-37d8fda51b12: 0.0%
Covered Lines: 4768
Relevant Lines: 5899
💛 - Coveralls

vbaranov pushed a commit that referenced this pull request May 29, 2019
@zachdaniel @vbaranov
#2047
9f5c077
@vbaranov vbaranov merged commit 7d78ed1 into master May 30, 2019
@vbaranov vbaranov deleted the include-contract-creation-internal-transactions branch May 30, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@vbaranov vbaranov vbaranov approved these changes

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to/from tx filters in address details page are broken
4 participants
@zachdaniel @coveralls @vbaranov @ayrat555