New tables for staking pools and delegators #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build bc053e24-e932-43e2-9ea9-ff51693d3a99
💛 - Coveralls |
pasqu4le
approved these changes
May 27, 2019
apps/explorer/lib/explorer/chain/import/runner/staking_pools.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/chain/import/runner/staking_pools_delegators.ex
Outdated
Show resolved
Hide resolved
vbaranov
approved these changes
May 28, 2019
zachdaniel
approved these changes
May 28, 2019
ayrat555
approved these changes
May 30, 2019
goodsoft
reviewed
Jun 28, 2019
| [pool], | ||
| pool.is_active == true and | ||
| pool.is_deleted == false and | ||
| pool.is_validator == true |
There was a problem hiding this comment.
This is a minor comment, and the PR is merged anyway, but if you decide to change this code at some point, I would suggest using simplified where syntax here:
where(query, is_active: true, is_deleted: false, is_validator: true)
goodsoft
reviewed
Jul 2, 2019
| pool.delegators | ||
| |> Enum.map(&Map.get(&1, :changes)) | ||
| |> Enum.concat(acc) | ||
| end) |
There was a problem hiding this comment.
Enum.flat_map(pools, & &1.delegators.changes)?
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1709
Motivation
There is a need to store
staking poolsanddelegatorslist in the separate tables.In this PR I migrate
staking poolsfromaddress_namestable to thestaking_poolstable and addstaking_pools_delegatorstable to storedelegators.Changelog
staking_poolstable and schemastaking_pools_delegatorstable and schemaaddress_namestable to thestaking_poolstablePoolsReaderto fetchdelegatorsdelegatorsinserting