-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BlocksTransactionsMismatch temporary fetcher #2027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a problem that was found with this fetcher: block with no transactions were not taken into account, so they were not checked and never had their `refetch_needed` field set to false.
pasqu4le
force-pushed
the
fix-block-transaction-mismatch-fetcher
branch
from
May 25, 2019 15:58
befda9e
to
1bd2dcd
Compare
Pull Request Test Coverage Report for Build 82e98b46-04c1-4142-98c6-85fe40679b17
💛 - Coveralls |
ayrat555
approved these changes
May 27, 2019
It is unnecessary to set `refetch_needed` to blocks that do not yet have a consensus, so this small change can save some time in the migration and avoid some checking from the temporary fetcher.
saneery
approved these changes
May 27, 2019
vbaranov
approved these changes
May 28, 2019
zachdaniel
approved these changes
May 28, 2019
This was referenced Jun 4, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
This solves a problem that was found with
BlocksTransactionsMismatch
temporary fetcher:block with no transactions were not taken into account, so they were not checked and never had their
refetch_needed
field set to false.Additionally, a
consensus
filtering has been added to theAddRefetchNeededToBlock
migration to save some unnecessary update in it and some checks from the temporary fetcher.Checklist for your PR
CHANGELOG.md
with this PR