Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async items loading #2012

Merged
merged 21 commits into from
May 28, 2019
Merged

async items loading #2012

merged 21 commits into from
May 28, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented May 23, 2019

Resolves #2011

Progress

  • Address tokens tab
  • Address logs tab
  • Block transactions
  • Transaction logs tab
  • Transaction token transfer tab
  • Transaction internal transactions tab
  • Token inventory

@ayrat555 ayrat555 changed the title async loading [WIP] async loading May 23, 2019
@coveralls
Copy link

coveralls commented May 23, 2019

Pull Request Test Coverage Report for Build e4ea4bcb-78d0-4bdc-88d7-b1f79f6f0f8a

  • 43 of 63 (68.25%) changed or added relevant lines in 7 files are covered.
  • 15 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.4%) to 80.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/address_token_controller.ex 7 9 77.78%
apps/block_scout_web/lib/block_scout_web/controllers/tokens/inventory_controller.ex 8 10 80.0%
apps/block_scout_web/lib/block_scout_web/controllers/transaction_internal_transaction_controller.ex 7 9 77.78%
apps/block_scout_web/lib/block_scout_web/controllers/transaction_log_controller.ex 7 9 77.78%
apps/block_scout_web/lib/block_scout_web/controllers/transaction_token_transfer_controller.ex 7 9 77.78%
apps/block_scout_web/lib/block_scout_web/controllers/block_transaction_controller.ex 7 10 70.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_logs_controller.ex 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/views/address_view.ex 1 86.89%
apps/block_scout_web/lib/block_scout_web/controllers/address_logs_controller.ex 1 0.0%
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 87.84%
apps/block_scout_web/lib/block_scout_web/views/transaction_view.ex 3 78.16%
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 69.23%
Totals Coverage Status
Change from base Build ae1c527a-460d-4beb-a514-abe8b88d1fe8: -0.4%
Covered Lines: 4755
Relevant Lines: 5880

💛 - Coveralls

@ayrat555 ayrat555 changed the title [WIP] async loading async items loading May 24, 2019
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on stg. Looks good to me.

One thing I noticed. I unsure, that this is related directly to this PR:
./address/0x52bc44d5378309ee2abf1539bf71de1b7d7be3b5/internal_transactions
Screenshot 2019-05-27 at 11 47 25

Empty internal txs tab with visible pagination and no fallback box when there are no items.

@ayrat555
Copy link
Contributor Author

@vbaranov fix for visible pagination is in master.

@vbaranov
Copy link
Member

@ayrat555 I mean hiding of pagination works well on staging (master + your PR is already there). The problem is only with this particular case. I rather think, that in this case, internal txs exist for this address (this why we see pagination and we don't see the box "There are no internal transactions for this transaction.
"), but the strange thing, that we don't see those internal txs.

Copy link
Contributor

@saneery saneery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbaranov vbaranov merged commit 075decf into master May 28, 2019
@vbaranov vbaranov deleted the ab-make-pages-async branch May 28, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make data loading async
6 participants