Get estimated count of blocks when cache is empty #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build b28c70cd-417c-4911-8ede-ff5e1b76ee5d
💛 - Coveralls |
vbaranov
reviewed
May 22, 2019
| @@ -1997,7 +1997,9 @@ defmodule Explorer.Chain do | |||
| cached_value = BlockCountCache.count() | |||
|
|
|||
| if is_nil(cached_value) do | |||
| block_consensus_count() | |||
There was a problem hiding this comment.
@saneery should we remove or mark with the comment, that block_consensus_count function is not used anymore?
There was a problem hiding this comment.
yes, I think, we can just remove this function
vbaranov
approved these changes
May 22, 2019
zachdaniel
approved these changes
May 22, 2019
ayrat555
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replace
block_consensus_countfunction with an estimated count of blocks when the cache is empty.Get 90% of the estimated count, because consensus blocks are ~90% of the total count.