Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude empty contracts by default #1952

Merged
merged 1 commit into from
May 15, 2019
Merged

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented May 14, 2019

Resolves #1942

Changelog

Enhancements

  • Exclude empty contracts by default from the unverified and not_decompiled filters. Add an empty filter to fetch contracts that have an empty bytecode.

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned zachdaniel May 14, 2019
@ghost ghost added the in progress label May 14, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build bdbcc483-c150-412a-b84e-996bced5453d

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 81.85%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/api/rpc/contract_controller.ex 0 1 0.0%
apps/explorer/lib/explorer/chain.ex 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
Totals Coverage Status
Change from base Build 24b8e670-bf87-4f35-bc1b-00ba852a442d: 0.1%
Covered Lines: 4654
Relevant Lines: 5686

💛 - Coveralls

@vbaranov vbaranov merged commit da92db0 into master May 15, 2019
@vbaranov vbaranov deleted the skip-empty-contracts branch May 15, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude smart-contracts with empty bytecode from the listcontracts API endpoint
5 participants