Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) status label alignment #1926

Merged
merged 2 commits into from
May 12, 2019
Merged

(fix) status label alignment #1926

merged 2 commits into from
May 12, 2019

Conversation

gabitoesmiapodo
Copy link
Contributor

@gabitoesmiapodo gabitoesmiapodo commented May 10, 2019 •
edited
Loading

Closes #1883

Motivation

To fix this.

Screenshot 2019-05-03 at 11 38 13

It should work fine now.

Changelog

Bug Fixes

  • Fix status label text alignment.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@gabitoesmiapodo gabitoesmiapodo self-assigned this May 10, 2019
@ghost ghost added the in progress label May 10, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5ee391f6-59a7-4297-83fb-22dfeff46678

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.1%) to 77.75%
Totals Coverage Status
Change from base Build b3d83305-6115-4bed-8132-9fa5906ada79: -4.1%
Covered Lines: 4410
Relevant Lines: 5672
💛 - Coveralls

@vbaranov vbaranov merged commit 0485801 into master May 12, 2019
@ghost ghost removed the in progress label May 12, 2019
@vbaranov vbaranov deleted the fix/#1883-wrong-alignment-of-error-in-the-new-design- branch May 12, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery Awaiting requested review from saneery

Assignees

@gabitoesmiapodo gabitoesmiapodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong alignment of error in the new design
4 participants
@gabitoesmiapodo @coveralls @vbaranov @ayrat555