Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Chore) Add -f flag to clear_build.sh script delete static folder #1837

Merged
merged 4 commits into from
Apr 26, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Apr 25, 2019

Motivation

Add the ability to delete a folder with static assets before the launching of another Blockscocut instance.

Changelog

Enhancements

  • -f flag has been added to clear_build.sh script to be able to also delete ./priv/static/ folder before the launching of another Blosckout instance

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov Apr 25, 2019
@ghost ghost added the in progress label Apr 25, 2019
@vbaranov vbaranov changed the title Add --f flag to clear_build.sh script delete static folder (Chore) Add --f flag to clear_build.sh script delete static folder Apr 25, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed in progress labels Apr 25, 2019
@ghost ghost added the in progress label Apr 25, 2019
@coveralls
Copy link

coveralls commented Apr 25, 2019

Pull Request Test Coverage Report for Build fa121281-1714-4534-b337-7b83e53cd6da

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 82.378%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
Totals Coverage Status
Change from base Build 3a837abf-ea5a-4e18-9331-4e90fed4c037: 0.2%
Covered Lines: 4455
Relevant Lines: 5408

💛 - Coveralls

Copy link
Contributor

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t it be -f or —force? Doesn’t really matter though.

@vbaranov
Copy link
Member Author

Thanks @zachdaniel. You are completely right. Changed to -f.

@vbaranov vbaranov changed the title (Chore) Add --f flag to clear_build.sh script delete static folder (Chore) Add -f flag to clear_build.sh script delete static folder Apr 25, 2019
@vbaranov vbaranov merged commit c85e9d9 into master Apr 26, 2019
@ghost ghost removed the in progress label Apr 26, 2019
@vbaranov vbaranov deleted the update-clear-script branch April 26, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants