Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Chore) Clear build artefacts script #1814

Merged
merged 2 commits into from
Apr 24, 2019
Merged

(Chore) Clear build artefacts script #1814

merged 2 commits into from
Apr 24, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Apr 23, 2019

Motivation

To prepare code for deployment to the instance after local testing we need to clear build artefacts. We do it manually now.

Changelog

Enhancements

  • ./rel/commands/clear_build.sh bash script has been added, which removes all of those artefacts

  • I've updated deployment instruction here: https://forum.poa.network/t/deploying-blockscout-with-terraform/1952#preparing-blockscout.

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov Apr 23, 2019
@ghost ghost added the in progress label Apr 23, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed in progress labels Apr 23, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1eb88e1f-16a6-4582-91d6-820fda41a64d

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 82.368%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 3 85.19%
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 69.23%
Totals Coverage Status
Change from base Build e1558521-716b-44a8-8013-18178ccc355a: -0.02%
Covered Lines: 4438
Relevant Lines: 5388

💛 - Coveralls

Copy link
Contributor

@goodsoft goodsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using git clean -x/-X though?

@vbaranov vbaranov merged commit 041f897 into master Apr 24, 2019
@vbaranov vbaranov deleted the clear-build-script branch April 24, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants