-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pagination to addresses page #1812
Conversation
Pull Request Test Coverage Report for Build 9f0f7269-a677-4bf2-b173-b2f7038573ca
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I see this description:
https://github.com/poanetwork/blockscout/blob/01356013ce4cd75c84e9fc7ee1103d7ba1f86bed/apps/explorer/lib/explorer/chain.ex#L1120
I think it is incompatible with your changes. Please, update it. And also please drop some comments in the PR: what is the new scheme of pagination.
-
I can't understand from the pagination view on what page am I. Let's add
(page {number_of_page})
likeShowing 12 addresses of 93 total addresses with a balance (page 2)
in the header. -
I have no ability to go back: there is no
Back
button. -
To switch the pagination view page I need to go to the bottom of the website page. It is not user-friendly. Let's repeat
Back
,Next
buttons on the top of the list also. -
And something strange with switching between pages: https://www.loom.com/share/e7fb398054944dc79ec0b04fe843cbae
@ayrat555 in the current design top view pagination could look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Top buttons set should be aligned with the text on the left by the bottom edge (as in screenshot I attached before)
-
I haven't seen the bottom buttons set. It should be there as before this PR.
@vbaranov what do you mean by bottom buttons? |
ok, it is the best practice to put pagination buttons in the top and to the bottom of the list. In the upcoming design update of Blockscout there are both: bottom and top set of buttons for pagination. |
@vbaranov should I add to the top and to the bottom? |
yes |
@vbaranov I addressed your comments. Can you please take a look? |
resolves #1782
fixes #1781
Changelog