Use eth_getUncleByBlockHashAndIndex for uncle block fetching #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
goodsoft
force-pushed
the
gs-uncle-blocks-api
branch
2 times, most recently
from
fe26a62
to
ed268c6
Compare
Pull Request Test Coverage Report for Build 7d057ddf-d894-418b-84c7-d833c6d03185
💛 - Coveralls |
goodsoft
force-pushed
the
gs-uncle-blocks-api
branch
5 times, most recently
from
93b09b2
to
44ca4ff
Compare
goodsoft
added
ready for review
zachdaniel
approved these changes
Apr 22, 2019
Parity returns `null` for many uncle blocks, if they are fetched using `eth_getBlockByHash`. This is most probably caused by the fact that Parity only keeps full block data for recent non-consensus blocks. This causes uncle_block fetcher to loop endlessly trying to fetch "missing" blocks, hogging both app server and Parity resources. Instead, we use `eth_getUncleByBlockHashAndIndex` method, which works for all uncle blocks. As we didn't previously store index of an uncle block within a nephew block, a new field and a temporary fixup fetcher is added to get the index from nephew blocks.
goodsoft
force-pushed
the
gs-uncle-blocks-api
branch
from
dd84bb9
to
8e6ee4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1798
Motivation
Parity returns
nullfor many uncle blocks, if they are fetched usingeth_getBlockByHash. This is most probably caused by the fact that Parity only keeps full block data for recent non-consensus blocks.This causes uncle_block fetcher to loop endlessly trying to fetch "missing" blocks, hogging both app server and Parity resources.
Changes
Instead, we use
eth_getUncleByBlockHashAndIndexmethod, which works for all uncle blocks.As we didn't previously store index of an uncle block within a nephew block, a new field and a temporary fixup fetcher is added to get the index from nephew blocks.
Checklist for your PR
CHANGELOG.mdwith this PR