-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ERC-721 info to transaction overview page #1789
Conversation
Pull Request Test Coverage Report for Build 988fc4bd-afb5-4412-bb6e-ac38d49c3ade
💛 - Coveralls |
# https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/token/ERC721/ERC721.sol#L35 | ||
{from_address, to_address} = | ||
case {to_string(input), value} do | ||
{"0x23b872dd" <> params, ^zero_wei} -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 can we add a comment here and below to which method it belongs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though, I'm not a fan of putting token transfer parsing logic in Web UI.
Especially when we parse them out in indexer already anyway.
I hope this won't stay past #1792.
with #1777 resolves #1732
Changelog