Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 0x0..0 from tests #1744

Merged
merged 4 commits into from
Apr 16, 2019
Merged

remove 0x0..0 from tests #1744

merged 4 commits into from
Apr 16, 2019

Conversation

ayrat555
Copy link
Contributor

in this PR #1614 we stopped fetching coin balance for 0x0..0 Because of it sometimes some tests may fail

Changelog

  • remove 0x0..0 from tests

@ghost ghost assigned ayrat555 Apr 12, 2019
@ghost ghost added the in progress label Apr 12, 2019
saneery
saneery reviewed Apr 12, 2019
View reviewed changes
Copy link
Contributor

@saneery saneery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use the not same name for variable and function?

@goodsoft
Copy link
Contributor

Any example of failing test?

@ayrat555
Copy link
Contributor Author

@goodsoft try running mix test test/indexer/transform/address_token_balances_test.exs:32

@coveralls
Copy link

coveralls commented Apr 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2d8eff3d-6d89-4f54-a070-e171252b3a54

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 83.286%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 68.0%
Totals Coverage Status
Change from base Build 0062ecc9-bca3-469e-baff-8bc792823056: 0.04%
Covered Lines: 4420
Relevant Lines: 5307
💛 - Coveralls

@ayrat555 ayrat555 merged commit 5b10a8c into master Apr 16, 2019
@ayrat555 ayrat555 deleted the ab-remove-burn-address-from-tests branch April 16, 2019 07:47
@ghost ghost removed the in progress label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saneery saneery saneery left review comments

@zachdaniel zachdaniel zachdaniel approved these changes

@goodsoft goodsoft goodsoft approved these changes

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayrat555 @goodsoft @coveralls @zachdaniel @saneery