-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add RSK Support #1742
Merged
Merged
Feat: Add RSK Support #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned zachdaniel
Apr 11, 2019
ghost
added
the
in progress
label
Apr 11, 2019
zachdaniel
force-pushed
the
rsk-support
branch
2 times, most recently
from
April 11, 2019 20:59
b48fd5e
to
60e8ae9
Compare
Pull Request Test Coverage Report for Build 282dfcf3-8667-40c3-85d7-1acb0ebc30c1
💛 - Coveralls |
goodsoft
reviewed
Apr 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions before I approve:
zachdaniel
force-pushed
the
rsk-support
branch
4 times, most recently
from
April 12, 2019 16:30
406579e
to
abc9a86
Compare
goodsoft
approved these changes
Apr 12, 2019
ayrat555
approved these changes
Apr 15, 2019
ghost
added
the
in progress
label
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changelog
Enhancements
CHANGELOG.md
with this PRI added tests to cover the incrementing of the rate limit, but I think testing the actual rate limit + wait combo itself would just introduce flaky tests at the expense of testing pretty straightforward code. I can rearchitect it to be better for that kind of testing, but that would probably take more time than it is worth.