Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty block time #1740

Merged
merged 3 commits into from
Apr 11, 2019
Merged

fix empty block time #1740

merged 3 commits into from
Apr 11, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #1737

Changelog

  • if the database has only one block on demand balance fetcher fails

@ghost ghost assigned ayrat555 Apr 11, 2019
@ghost ghost added the in progress label Apr 11, 2019
@coveralls
Copy link

coveralls commented Apr 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 4d9ec7e2-8f12-4c9e-b385-ed0ba35e1ca3

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 83.412%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 1 85.19%
Totals Coverage Status
Change from base Build a8eb969c-473f-4d95-a6ef-358f6120d490: 0.3%
Covered Lines: 4395
Relevant Lines: 5269
💛 - Coveralls

@ayrat555 ayrat555 requested a review from saneery April 11, 2019 12:05
@ayrat555 ayrat555 merged commit b40b3b1 into master Apr 11, 2019
@ayrat555 ayrat555 deleted the ab-fix-empty-block-time branch April 11, 2019 13:26
@ghost ghost removed the in progress label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@goodsoft goodsoft goodsoft approved these changes

@saneery saneery Awaiting requested review from saneery

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid arithmetic expression
4 participants
@ayrat555 @coveralls @goodsoft @zachdaniel