Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix average block time calculation #1714

Merged
merged 5 commits into from
Apr 9, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Apr 8, 2019

Average block time was recalculated when new blocks were processes. But since block are not added consecutively average block time is getting wronger over time

Changelog

  • fix average block time calculation

@ghost ghost assigned ayrat555 Apr 8, 2019
@ghost ghost added the in progress label Apr 8, 2019
@coveralls
Copy link

coveralls commented Apr 9, 2019

Pull Request Test Coverage Report for Build 99f435a8-6a15-40e1-9854-0d5dadcf4fa2

  • 5 of 8 (62.5%) changed or added relevant lines in 2 files are covered.
  • 14 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.3%) to 83.028%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/counters/average_block_time.ex 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 1 65.85%
apps/indexer/lib/indexer/token/fetcher.ex 1 78.57%
apps/indexer/lib/indexer/token_balance/fetcher.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 2 91.67%
apps/explorer/lib/explorer/counters/average_block_time.ex 8 47.62%
Totals Coverage Status
Change from base Build b28bfca6-f322-47ca-ba57-bc5965a78876: -0.3%
Covered Lines: 4447
Relevant Lines: 5356

💛 - Coveralls

@ayrat555 ayrat555 merged commit f521603 into master Apr 9, 2019
@ayrat555 ayrat555 deleted the ab-fix-average-block-time branch April 9, 2019 10:59
@ghost ghost removed the in progress label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants