add postgres full text search by tokens #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 39592cff-fe6f-4861-be8f-9d0d41c303b5
💛 - Coveralls |
ayrat555
changed the title
zachdaniel
approved these changes
Apr 15, 2019
goodsoft
approved these changes
Apr 15, 2019
| script-src 'self' 'unsafe-inline' 'unsafe-eval';\ | ||
| style-src 'self' 'unsafe-inline' 'unsafe-eval' https://fonts.googleapis.com;\ | ||
| script-src 'self' 'unsafe-inline' 'unsafe-eval' http://nico-amsterdam.github.io;\ | ||
| style-src 'self' 'unsafe-inline' 'unsafe-eval' https://fonts.googleapis.com http://nico-amsterdam.github.io;\ |
There was a problem hiding this comment.
Shouldn't we force HTTPS here?
| .hide-not-found div.awesomplete .awe-not-found {border-color: lightblue} | ||
|
|
||
| div.awesomplete .awe-not-found {border: 2px solid red} | ||
| </style> |
There was a problem hiding this comment.
I see this code in the README of Awesomplete, but can't it be installed via NPM and imported from JS/CSS?
I don't like including scripts from third-party hosts, because if a script loads too slowly, the whole page will be loaded slowly.
There was a problem hiding this comment.
Unfortunately, it can't be installed from npm
|
|
||
| assert Enum.count(json_response(conn, 200)) == 1 | ||
| end | ||
| end |
There was a problem hiding this comment.
Should probably include one more matching and non-matching token for better coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1670
fixes #1745
fixes #403
Changelog:
phantomjswith Chrome Headless for wallaby