Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a checklist to the PR template #1693

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Add a checklist to the PR template #1693

merged 1 commit into from
Apr 8, 2019

Conversation

goodsoft
Copy link
Contributor

@goodsoft goodsoft commented Apr 2, 2019

We tend to forget adding changelog entries for PRs, so here's an extra reminder

@ghost ghost assigned goodsoft Apr 2, 2019
@ghost ghost added the in progress label Apr 2, 2019
@goodsoft goodsoft added ready for review This PR is ready for reviews. and removed in progress labels Apr 2, 2019
@coveralls
Copy link

coveralls commented Apr 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build a0a1cc83-ece4-462c-807e-dff5b2e9c8ca

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 82.972%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 5 65.85%
Totals Coverage Status
Change from base Build 5e188dbd-8fed-40bc-83d5-2bd7a60931af: -0.5%
Covered Lines: 4444
Relevant Lines: 5356
💛 - Coveralls

@goodsoft
Add a checklist to the PR template
c5de3b4 
We tend to forget adding changelog entries for PRs, so here's an extra reminder
@ghost ghost added the in progress label Apr 8, 2019
@goodsoft goodsoft merged commit ae667df into master Apr 8, 2019
@ghost ghost removed the in progress label Apr 8, 2019
@goodsoft goodsoft deleted the gs-update-pr-template branch April 8, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@goodsoft goodsoft

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goodsoft @coveralls @zachdaniel @ayrat555