Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow searching by token symbol #1558

Merged
merged 7 commits into from
Mar 14, 2019
Merged

allow searching by token symbol #1558

merged 7 commits into from
Mar 14, 2019

Conversation

ayrat555
Copy link
Contributor

resolves #1535

Changelog

  • allow searching by token symbol

@ghost ghost assigned ayrat555 Mar 13, 2019
vbaranov
vbaranov approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 Does it make sense to add additional tests, where lowercase and mixed-case token names are validated?

@ayrat555
Copy link
Contributor Author

ayrat555 commented Mar 13, 2019 •
edited
Loading

@vbaranov I added case-insensitive search

@coveralls
Copy link

coveralls commented Mar 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2f147dfa-e802-47ee-8ebb-0455b7d4eaf1

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 84.44%
Totals Coverage Status
Change from base Build 49a8d5e7-d319-4522-8646-3dce1c179cf5: 1.2%
Covered Lines: 4298
Relevant Lines: 5090
💛 - Coveralls

@vbaranov
Copy link
Member

@ayrat555 could you please resolve conflicts?

@vbaranov vbaranov merged commit f890d90 into master Mar 14, 2019
@ghost ghost removed the in progress label Mar 14, 2019
@vbaranov vbaranov deleted the ab-search-by-token-name branch March 14, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@vbaranov vbaranov vbaranov approved these changes

@goodsoft goodsoft Awaiting requested review from goodsoft

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: search token by symbol
4 participants
@ayrat555 @coveralls @vbaranov @zachdaniel