Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test that fails every 1st day of the month #1510

Merged
merged 1 commit into from
Mar 1, 2019
Merged

fix test that fails every 1st day of the month #1510

merged 1 commit into from
Mar 1, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Mar 1, 2019 •
edited
Loading

Motivation

The test was failing every 1st day of the month. I think it was caused by a date comparison issue

Changelog

  • fix test that fails every 1st day of the month

@ghost ghost assigned ayrat555 Mar 1, 2019
@ghost ghost added the in progress label Mar 1, 2019
@ayrat555 ayrat555 requested a review from vbaranov March 1, 2019 13:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7df2bf51-ee23-4cc1-ba34-18c71baa9c47

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.845%
Totals Coverage Status
Change from base Build 306eb0ae-085c-4d88-91c7-b1d4cc1dd12e: 0.0%
Covered Lines: 4266
Relevant Lines: 5028
💛 - Coveralls

@vbaranov vbaranov merged commit fbd474a into master Mar 1, 2019
@ghost ghost removed the in progress label Mar 1, 2019
@vbaranov vbaranov deleted the ab-fix-failing-test branch March 14, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@igorbarinov igorbarinov Awaiting requested review from igorbarinov

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayrat555 @coveralls @vbaranov