Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit geth sync to 128 blocks #1487

Merged
merged 3 commits into from
Feb 27, 2019
Merged

limit geth sync to 128 blocks #1487

merged 3 commits into from
Feb 27, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #1433

Motivation

ethereum/go-ethereum#18441

Changelog

  • limit geth internal transaction syncing to 128 blocks

@ghost ghost assigned ayrat555 Feb 26, 2019
@ghost ghost added the in progress label Feb 26, 2019
@coveralls
Copy link

coveralls commented Feb 26, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2141e391-6e68-4912-80b2-a2361359f37c

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 84.64%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 5 8 62.5%
Totals Coverage Status
Change from base Build c594c041-b9f2-4ab7-aa28-9d6550e4c295: -0.04%
Covered Lines: 4254
Relevant Lines: 5026
💛 - Coveralls

acravenho
acravenho approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@acravenho acravenho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Now that we have the code_fetcher we are still able to have all functionality with smart contracts. Good work 👍

@acravenho acravenho merged commit e0b4ac6 into master Feb 27, 2019
@ghost ghost removed the in progress label Feb 27, 2019
@acravenho acravenho deleted the ab-geth-limit-sync-to-128-blocks branch February 27, 2019 16:45
@ayrat555 ayrat555 mentioned this pull request Mar 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acravenho acravenho acravenho approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geth archive node: required historical state unavailable (reexec=128)
4 participants
@ayrat555 @coveralls @zachdaniel @acravenho