Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action failing with setup that has previously been working #135

Closed
Carson-JG opened this issue Jul 3, 2024 · 30 comments · Fixed by microsoft/FluidFramework#21782
Closed

Action failing with setup that has previously been working #135

Carson-JG opened this issue Jul 3, 2024 · 30 comments · Fixed by microsoft/FluidFramework#21782

Comments

@Carson-JG
Copy link

Carson-JG commented Jul 3, 2024 •
edited
Loading

Getting the following error when running action. Action was working yesterday, and has worked for almost a year.

Running self-installer...
   WARN  GET https://registry.npmjs.org/pnpm error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
   WARN  GET https://registry.npmjs.org/pnpm error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
   ERR_PNPM_META_FETCH_FAIL  GET https://registry.npmjs.org/pnpm: Value of "this" must be of type URLSearchParams
Error: Something went wrong, self-installer exits with code 1
Installation Completed!

This is our setup:

      - name: Install pnpm
        uses: pnpm/action-setup@v2
        with:
          version: latest
@shreyas-iyer
Copy link

shreyas-iyer commented Jul 3, 2024 •
edited
Loading

Seeing this as well with version: 8.11.0. Was totally fine a couple hours ago.

@haq204
Copy link

haq204 commented Jul 3, 2024

can confirm seeing the issue as on 8.11.0

@Carson-JG Carson-JG changed the title Action Failing with Setup that has previously been working Action failing with setup that has previously been working Jul 3, 2024
@fvictorio
Copy link

Upgrading the action to v4 seems to fix this:

        uses: pnpm/action-setup@v4

@craftyc0der
Copy link

upgrading to v4 fixes this for me

kschelonka added a commit to Pocket/pocket-monorepo that referenced this issue Jul 3, 2024
@kschelonka
chore(deps): upgrade pnpm action-setup to v4
9ac1f61 
Fix failing setup step

Ref: pnpm/action-setup#135
@kschelonka kschelonka mentioned this issue Jul 3, 2024
Merged
kschelonka added a commit to Pocket/pocket-monorepo that referenced this issue Jul 3, 2024
@kschelonka
chore(deps): upgrade pnpm action-setup to v4
3bfcf26 
Fix failing setup step

Ref: pnpm/action-setup#135
@jmcgrath207
Copy link

Upgrading the action to v4 seems to fix this:

        uses: pnpm/action-setup@v4

This fix worked when jumping from pnpm/action-setup@v2 . Thanks @fvictorio !

github-merge-queue bot pushed a commit to Pocket/pocket-monorepo that referenced this issue Jul 3, 2024
@kschelonka
chore(deps): upgrade pnpm action-setup to v4 (#631)
b426842 
Fix failing setup step

Ref: pnpm/action-setup#135
@chris24sahadeo
Copy link

Also got this error on v2. v4 fixes it

@wittjosiah wittjosiah mentioned this issue Jul 3, 2024
Merged
enuesaa added a commit to enuesaa/kakkofn that referenced this issue Jul 3, 2024
@enuesaa
fix(ci): pnpm/action-setup@v2 failed due to an error `  ERR_PNPM_META…
4648baa 
…_FETCH_FAIL  GET https://registry.npmjs.org/pnpm: Value of "this" must be of type URLSearchParams`

see pnpm/action-setup#135
enuesaa added a commit to enuesaa/kakkofn that referenced this issue Jul 3, 2024
@enuesaa
fix(ci): pnpm/action-setup@v2 failed due to an error ` ERR_PNPM_META_…
787ffc2 
…FETCH_FAIL  GET https://registry.npmjs.org/pnpm: Value of "this" must be of type URLSearchParams`

see pnpm/action-setup#135
@nhuray
Copy link

nhuray commented Jul 3, 2024

We also upgrade to v4 and it resolves the issue !

This was referenced Jul 3, 2024
Merged
Merged
Merged
Merged
@diegoalzate diegoalzate mentioned this issue Jul 3, 2024
Merged
caleb531 added a commit to caleb531/personal-website that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
beaaf4a 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/2fa-code-generator that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
f064e73 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/connect-four that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
c33fabd 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/faith-dashboard that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
8ab9161 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/flip-book that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
3a80513 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/pswd-matcher that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
1a272b8 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/rollup-plugin-peggy that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
1496fa5 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/truthy that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
5490ae6 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/workday-time-calculator that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
f61c529 
Per <pnpm/action-setup#135>.
caleb531 added a commit to caleb531/youversion-suggest-api that referenced this issue Jul 3, 2024
@caleb531
Fix pnpm installation error on CI
6a2e968 
Per <pnpm/action-setup#135>.
@ishiko732 ishiko732 mentioned this issue Jul 6, 2024
Merged
@panteliselef panteliselef mentioned this issue Jul 7, 2024
Merged
scarf005 added a commit to cataclysmbnteam/Cataclysm-BN that referenced this issue Jul 8, 2024
@scarf005
ci: bump withastro/action to v2
ee3af1a 
fixes [`ERR_INVALID_THIS` error](pnpm/action-setup#135) by bumping [pnpm/action-setup](https://github.com/withastro/action/blob/v2.0.1/action.yml#L60)
@scarf005 scarf005 mentioned this issue Jul 8, 2024
Merged
2 tasks
scarf005 added a commit to cataclysmbnteam/Cataclysm-BN that referenced this issue Jul 8, 2024
@scarf005
ci: bump withastro/action to v2 (#4959)
5cf4962 
fixes [`ERR_INVALID_THIS` error](pnpm/action-setup#135) by bumping [pnpm/action-setup](https://github.com/withastro/action/blob/v2.0.1/action.yml#L60)
@CollinHerber
Copy link

Are we getting a fix for this in the v4 and v3 versions of the action? I am seeing this with 9.4.0 of pnpm and v4 of the action.

@zkochan
Copy link
Member

zkochan commented Jul 8, 2024

This issue was reproducible only in v2 of the action as far as I can tell. As you can see, everyone is upgrading to v4 to fix the issue.

@nubunto
Copy link

nubunto commented Jul 8, 2024

only the modern javascript ecosystem can have software be broken absolutely out of nowhere

@CollinHerber
Copy link

I've triple checked that I'm using v4 . I'm even using the direct commit hash instead of just v4 and still seeing this.

katywings added a commit to katywings/vinxi that referenced this issue Jul 9, 2024
@katywings
ci: upgrade pnpm/action-setup to v4
991e85f 
Refs: pnpm/action-setup#135
@katywings katywings mentioned this issue Jul 9, 2024
Merged
@zkochan
Copy link
Member

zkochan commented Jul 9, 2024

@CollinHerber do you have a link to the action? If no, you can just use corepack instead to install pnpm. Like here:

https://github.com/pnpm/pnpm.io/blob/6e37a4afdf6cac6dbe37b8e3aea709ce85efaa77/.github/workflows/ci.yml#L19-L22

himself65 added a commit to himself65/waku that referenced this issue Jul 10, 2024
@himself65
ci: update pnpm setup (dai-shi#775)
b7b88a1 
Upstream:
pnpm/action-setup#135 (comment)
danielnaab added a commit to GSA-TTS/forms that referenced this issue Jul 10, 2024
@natashapl @danielnaab
Updated the focus on the drag list and UI updates (#248)
8c8994d 
* Updated the focus on the drag list and UI updates

* Add link to nvmrc and NVM repository

* Upgrade to pnpm/action-setup@v4 (v2 is now incompatible with npm - pnpm/action-setup#135)

* Fix test of page title editing

* Fixed the style of the draggable item states

* Fixed the style of the draggable item states

---------

Co-authored-by: Daniel Naab <[email protected]>
Co-authored-by: Daniel Naab <[email protected]>
@ebeshero ebeshero mentioned this issue Jul 13, 2024
Closed
@liuyib liuyib mentioned this issue Jul 17, 2024
Merged
18 tasks
@bayological bayological mentioned this issue Jul 17, 2024
Merged
@confused-Techie confused-Techie mentioned this issue Jul 19, 2024
Merged
@denbite denbite mentioned this issue Jul 21, 2024
Merged
4 tasks
@cs-ade-adesokan cs-ade-adesokan mentioned this issue Jul 22, 2024
Open
tonyxiao added a commit to openint-bak/openint that referenced this issue Jul 25, 2024
@tonyxiao
Fix pnpm setup
2741181 
pnpm/action-setup#135
@typicalninja typicalninja mentioned this issue Jul 30, 2024
Merged
@quantuminformation
Copy link

any quick fix for
image

@Gustav-Eikaas Gustav-Eikaas mentioned this issue Aug 13, 2024
Merged
@circle-hotaru circle-hotaru mentioned this issue Sep 2, 2024
Merged
aloisklink pushed a commit to mermaid-js/mermaid that referenced this issue Oct 2, 2024
@frantic1048 @aloisklink
[10] ci: upgrade to pnpm/action-setup@v4 to avoid CI failures
fc61512 
see: pnpm/action-setup#135

(cherry picked from commit fde668a)
travis added a commit to storacha/blob-fetcher that referenced this issue Oct 2, 2024
@travis
fix: upgrade github action
160045e 
seems to be broken! pnpm/action-setup#135
@StefanMorar
Copy link

We previously used pnpm version 7 (7.30.3) with pnpm/action-setup@v3. Updating the action to pnpm/action-setup@v4 alone did not fix the registry.npmjs errors.

We had to update the pnpm version too. Using pnpm 8 (8.15.9) with pnpm/action-setup@v4 fixed the errors.

Merged
@snitin315 snitin315 mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Upgrade pnpm/action-setup to v4 tylerbutler/FluidFramework