Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListView Drag and Drop option #679

Closed
aaclage opened this issue Oct 5, 2020 · 4 comments
Closed

ListView Drag and Drop option #679

aaclage opened this issue Oct 5, 2020 · 4 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@aaclage
Copy link
Contributor

aaclage commented Oct 5, 2020

Category

[x] Enhancement

[ ] Bug

[x] Question

Version

Please specify what version of the library you are using: [ 2.0.0.0 ]

Submission Guidelines

i was looking @pnp/spfx-controls-react and was surprise the control ListView didn't have a "dragDropFiles" property.

I access to the github to see the code and expand the control ListView to have a "dragDropFiles" properties, with [True/False] to enable/disable and a custom handler "handleDrop" that retrieves the files content.

Business case:
This could be used by developers that need access to files to sent into SharePoint library or other requirements that need to
manage the binary of files.

Questions:
There is any specific to don't have it?
Makes sense to have it?
If yes to all and approval from the owners, can i make PR with associated changes, documentation, code style, comments and process to be align with the documentation in pnp to include this small feature?

Visual expectation:
image

image

Thanks!

@ghost
Copy link

ghost commented Oct 5, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Oct 5, 2020
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Oct 5, 2020

Thank you @aaclage for the suggestion!
It could be a great addition to the control!

@AJIXuMuK AJIXuMuK added help wanted type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Oct 5, 2020
@aaclage
Copy link
Contributor Author

aaclage commented Oct 6, 2020

#682 follow up.

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed help wanted labels Oct 7, 2020
@AJIXuMuK AJIXuMuK added this to the 2.1.0 milestone Oct 7, 2020
@aaclage
Copy link
Contributor Author

aaclage commented Oct 8, 2020

Associated actions were made. I will close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants