Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItemAttachments fails in Microsoft Teams Tab SPFx applications #582

Closed
joeljeffery opened this issue Jun 13, 2020 · 2 comments
Closed
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@joeljeffery
Copy link
Contributor

Category

[ ] Enhancement

[X ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [1.18.0]

Expected / Desired Behavior / Question

ListItemAttachments control should work on a Teams Tab. The window.location change in the onClickHref handler won't work in Microsoft Teams due to IFRAME security.

Observed Behavior

Clicking on an attachment icon in view or edit mode from a Tab in Microsoft Teams causes the Tab to crash, and the navigation attempt getting blocked.

Steps to Reproduce

Build an SPFx Teams Tab app that uses the ListItemAttachments control. Add an attachment. Then try opening the attachment.

Joel Jeffery
w:joelblogs.co.uk
t:@joelblogs

@ghost
Copy link

ghost commented Jun 13, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 7, 2020

Thank you @joeljeffery for reporting and fixing the issue.
It will be available in the next release.
In a meanwhile you can test in in beta version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants