Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListItemAttachments and Hyphen #526

Closed
Gregghis opened this issue Apr 1, 2020 · 4 comments
Closed

ListItemAttachments and Hyphen #526

Gregghis opened this issue Apr 1, 2020 · 4 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone
1.18.0

Comments

@Gregghis
Copy link
Contributor

Gregghis commented Apr 1, 2020

#304 ## Category
[ ] Enhancement
[ x] Bug
The ListItemAttachments remove the hyphens from filename during upload
[ ] Question

Version

@pnp/[email protected]

Expected / Desired Behavior / Question

when I upload a file I'd like the name will not change

Observed Behavior

when I upload a file that contains an hyphen, the "-" char it is replaced by an empty string

Steps to Reproduce

Choose a file with filename "sam-ple.pdf", upload using drag & drop of file picker
it is uploaded with filename "sample.pdf"

Thanks!
@ghost
Copy link

ghost commented Apr 1, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Apr 1, 2020
@github-actions
Copy link

github-actions bot commented Apr 1, 2020

Thank you for submitting your first issue to this project.

@Gregghis
Copy link
Contributor Author

Gregghis commented Apr 1, 2020

I confirm this issue still persists with version 1.17.0

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Apr 12, 2020
@AJIXuMuK AJIXuMuK added this to the 1.18.0 milestone Apr 12, 2020
@AJIXuMuK
Copy link
Collaborator

The fix is available in beta version and will be included in 1.18.0

@estruyf estruyf mentioned this issue May 7, 2020
Merged
@evlo evlo mentioned this issue Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Milestone
1.18.0
Development

No branches or pull requests
2 participants
@AJIXuMuK @Gregghis