Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Provide a way to opt-out for PnP Telemetry #475

Closed
1 of 3 tasks
estruyf opened this issue Jan 29, 2020 · 4 comments
Closed
1 of 3 tasks

Telemetry: Provide a way to opt-out for PnP Telemetry #475

estruyf opened this issue Jan 29, 2020 · 4 comments
Assignees
Labels
status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail.

Comments

@estruyf
Copy link
Member

estruyf commented Jan 29, 2020

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [latest]

Expected / Desired Behavior / Question

Provide a way to opt-out for PnP telemetry.

@estruyf estruyf self-assigned this Jan 29, 2020
@estruyf estruyf added the status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. label Jan 29, 2020
@estruyf
Copy link
Member Author

estruyf commented Jan 29, 2020

This is available in the latest beta.

Screenshot 2020-01-29 22 17 28

Screenshot 2020-01-29 22 19 02

Screenshot 2020-01-29 22 17 44

@eduardpaul
Copy link
Contributor

Hello @estruyf and thank you very much for addressing this! :)

@nbelyh
Copy link
Contributor

nbelyh commented Nov 25, 2020

Was this merged in 2.1.0? I have tried to add this code on startup:

const telemetry = PnPTelemetry.getInstance();
telemetry.optOut();

But then opening the "Network" tab in Dev Tools shows that some (all?) telemetry calls are still there:
image

Or are these some other telemetry calls from those that have been disabled... or maybe I am missing something?
I have tried this from the workbench. May this be the reason? I.e. maybe it's the workbench posting the telemetry?

@joelfmrodrigues
Copy link
Collaborator

@nbelyh I believe that is just the default telemetry from the workbench. Closing this issue, but please open a new one if you find issues with the telemetry from the controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail.
Projects
None yet
Development

No branches or pull requests

4 participants