Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy Picker browse (tree view) doesn't work with SP 2016 On Premise #183

Closed
cameronsibbald opened this issue Nov 15, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@cameronsibbald
Copy link

cameronsibbald commented Nov 15, 2018

Category

[ ] Enhancement
[x] Bug
[ ] Question

Version

1.7.0 - Breaking changes around the minimum Office UI Fabric version require that we use 1.7.0 for SP 2016 On Premise support (RE: #149)

Expected / Desired Behavior / Question

The Taxonomy Picker browse panel (tree view) should be work with SP 2016 on premise

Observed Behavior

The following issues are observed when attempting to use the Taxonomy Picker in an on premise environment.

  • Clicking either Save or Cancel button (in the tree view) causes the spinner to appear and the panel "freezes" and remains open, unable to close via the panel close button, unable to cancel via the cancel button
  • if allowMultipleSelections is enabled, the same behavior as above is observed. In addition, the following error is reported every time a term is selected:
sp-webpart-workbench-assembly_en-us.js?version=1:174 Uncaught TypeError: sp_lodash_subset_1.uniqBy is not a function
    at TaxonomyPicker.termsChanged (TaxonomyPicker.tsx:176)
    at Term._handleChange (Term.tsx:33)
    at Checkbox._onChange (Checkbox.tsx:137)
    at Object.executeOnChange (sp-webpart-workbench-assembly_en-us.js?version=1:174)
    at h.o (sp-webpart-workbench-assembly_en-us.js?version=1:174)
    at Object.r (sp-webpart-workbench-assembly_en-us.js?version=1:174)
    at a (sp-webpart-workbench-assembly_en-us.js?version=1:174)
    at Object.s [as executeDispatchesInOrder] (sp-webpart-workbench-assembly_en-us.js?version=1:174)
    at f (sp-webpart-workbench-assembly_en-us.js?version=1:174)
    at m (sp-webpart-workbench-assembly_en-us.js?version=1:174)

Steps to Reproduce

  1. Clone the repo at https://github.com/cameronsibbald/spfx-controls-react
  2. Load the TestTaxonomyPicker web part into the workbench of a SP 2016 on premise environment
  3. Enter a valid term set id for your environment into the text box
  4. Click the "browse" icon to the right of the Taxonomy Picker field to open the browse panel (tree view)
  5. Attempt to Save or Cancel
@cameronsibbald cameronsibbald changed the title Taxonomy Picker doesn't work with SP 2016 On Premise (uniqBy) Taxonomy Picker doesn't work with SP 2016 On Premise Nov 15, 2018
@cameronsibbald cameronsibbald changed the title Taxonomy Picker doesn't work with SP 2016 On Premise Taxonomy Picker browse (tree view) doesn't work with SP 2016 On Premise Nov 15, 2018
@estruyf estruyf added bug and removed bug labels Dec 7, 2018
@AJIXuMuK AJIXuMuK self-assigned this Jun 13, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @cameronsibbald.

Sorry for not getting back to you with this issue.
If you're still interested - could you please check the latest beta version of the library and see if it works for you now.

@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants