Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting to EN-US language not working - empty labels and texts #85

Closed
wapster182 opened this issue Jul 29, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@wapster182
Copy link

Description

When your browser language is not in the translation libary (e.g. polish), it should default to en-US but this is not working.
You only see empty labels and no texts:

image

Steps to reproduce

  1. Set your browser language to something not included in the translation libary
  2. Open the app
  3. See missing labels and texts

Expected results

When detected browser language is not included in translation libary, it should fallback to default en-US.

Actual Results

It displays no text and empty labels:

image

Solution component

Power App

Operating system (environment)

Windows

Additional Info

No response

@wapster182 wapster182 added the bug Something isn't working label Jul 29, 2024
@alexc-MSFT
Copy link
Collaborator

@wapster182 thanks for spotting this, I'll take a look.

Also, we would love to get more translations into the solution so if you'd like to help and add Polish in there we would be most grateful.

Thanks

@alexc-MSFT
Copy link
Collaborator

@wapster182 I've now fixed this - thanks for your patience and good spot too.

The latest 1.1.3 release - https://github.com/pnp/provision-assist-m365/releases/tag/v1.1.3 contains the fix.

Or if you wish to use the V2 UI, the latest V2 release (2.0.1) also contains the fix.

Closing this issue now. Thanks

@wapster182
Copy link
Author

Great, thanks!
Do you have anything documented regarding to the V2 UI? The screenshots from the guide are still the V1.x UI, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants