Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp serve NODE_NO_HTTP2=1 #14

Closed
lovengren opened this issue Sep 27, 2018 · 3 comments
Closed

gulp serve NODE_NO_HTTP2=1 #14

lovengren opened this issue Sep 27, 2018 · 3 comments
Assignees
Labels

Comments

@lovengren
Copy link

First of all thanks for doing a great job creating docker images for the different SPFx versions. This really helps us as developers creating SPFx solutions across different versions.

However in recent versions of the images, with the introduction of Node v8, I have noted that I need to set an environment variable NODE_NO_HTTP2=1 as discussed here SharePoint/sp-dev-docs#1002 to be able to attach to the web server from my browser.

Would it be possible to include this environment variable in the images as a default setting?

@waldekmastykarz
Copy link
Member

Thank you for the kind words and great to hear you find the image useful! The env var you mentioned was necessary in some older versions of SPFx but shouldn't be necessary in the recent version. In which version of the SPFx are you experiencing this issue? What OS and browser are you using?

@lovengren
Copy link
Author

Thanks for the quick feedback. Good to hear that the issue was resolved in the recent versions.
After your reply I did some more digging to isolate the reason for the issue I'm seeing. I normally work on macOS Mojave and Google Chrome, where I have set up a dev user profile in Chrome to make it easier to switch between the different tenants I work on, without having to sign out of my own tenant. I have narrowed it down to be an issue with this profile as I don't see the issue when using either Safari og Google Chrome with the default profiles.
So I guess I'll just have to switch to the default profiles.
Thanks for helping out!

@waldekmastykarz
Copy link
Member

Great to hear it's working for you @lovengren! Thank you for sharing your findings and please don't hesitate to reach out if anything doesn't work as expected in the future 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants