Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled Promise rejection in loadPointCloud #82

Open
rooby opened this issue Feb 16, 2021 · 2 comments
Open

Unhandled Promise rejection in loadPointCloud #82

rooby opened this issue Feb 16, 2021 · 2 comments

Comments

@rooby
Copy link

rooby commented Feb 16, 2021

If the XHR request encounters any kind of errors the promise rejects, but the promise rejections aren't handled.
Seems like there are a few places in the code where promise rejections aren't handled.

@fahadm
Copy link
Collaborator

fahadm commented May 24, 2021

Can you provide a minimally reproducible example?

@kamilmingulov
Copy link
Contributor

Loader assumes that Response status is always 200 and attempts to access .json or .buffer both of which can be empty if request failed. I made it fail with 404 requesting nonexistent URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants