Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing punctuation #86

Closed
eric-s-s opened this issue Nov 30, 2017 · 3 comments
Closed

Missing punctuation #86

eric-s-s opened this issue Nov 30, 2017 · 3 comments
Labels

Comments

@eric-s-s
Copy link

Hello,

While looking through this question , I was looking at the punctuation in your code and the chinese language test in your tests. The Chinese comma (",") seems to missing from the punctuation in _tokenize, here. Since Chinese rarely uses periods or spaces, it was entirely possible that he was getting a maximum recursion error by have a space with a combination of 99 characters and commas. I thought I would let you know as I can't imagine the fix requires more than inserting that one character into the list.

@pndurette
Copy link
Owner

Sorry for the super long delay about this, but I wanted to thank you a lot for this. I had not seen the original issue (I should set a watch on SO), but I'm currently refactoring a lot of gTTS and this dragged me down quite an interesting rabbit hole and deeper underlying issues (which are fixed for the upcoming 2.0.0. I added the Chinese comma too! (but the problem was deeper than that!)

@pndurette pndurette added the bug label Mar 6, 2018
@eric-s-s
Copy link
Author

glad to hear it was helpful!

@pndurette pndurette mentioned this issue Apr 30, 2018
@pndurette
Copy link
Owner

gTTS 2.0.0 was released and should fix this! 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants